[PR #1067/3f434f3f backport][stable-3] In integration tests use a common AMI rather than hard coded per test #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
…#1067) In integration tests use a common AMI rather than hard coded per test Depends-On: #1068 SUMMARY Rather than hard coding the AMIs on a per-test basis, use a common AMI defined in setup_ec2_facts ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_asg_instance_refresh ec2_asg_lifecycle_hook ec2_asg_scheduled_action ec2_launch_template ec2_lc ec2_metric_alarm ec2_scaling_policy elb_network_lb elb_target elb_target_info ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Jill R <None> (cherry picked from commit 3f434f3)
|
cc @Zeekin @danquixote @garethr @jillr @marknet15 @markuman @s-hertel @tremble @wilvk @yaakov-github @Zeekin |
ansibullbot
added
community_review
feature
markuman
approved these changes
Apr 20, 2022
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-3/3f434f3f7f5bd736ee004ef88244bf6ec6436704/pr-1067
branch
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
… to the rule (ansible-collections#1589) cloudwatchevent_rule should return false when there is no change done to the rule SUMMARY Fixes ansible-collections#1080 ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/modules/cloudwatchevent_rule.py ADDITIONAL INFORMATION Reviewed-by: GomathiselviS Reviewed-by: Mark Chappell Reviewed-by: Jill R Reviewed-by: Alina Buzachis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1067 as merged into main (3f434f3).
Depends-On: #1068
SUMMARY
Rather than hard coding the AMIs on a per-test basis, use a common AMI defined in setup_ec2_facts
ISSUE TYPE
COMPONENT NAME
ec2_asg_instance_refresh
ec2_asg_lifecycle_hook
ec2_asg_scheduled_action
ec2_launch_template
ec2_lc
ec2_metric_alarm
ec2_scaling_policy
elb_network_lb
elb_target
elb_target_info
ADDITIONAL INFORMATION